Keyboard Numpad keys issue

classic Classic list List threaded Threaded
5 messages Options
Reply | Threaded
Open this post in threaded view
|

Keyboard Numpad keys issue

Jignesh Patel
Hi,

I have build Client and Server from 0.9.9 source.

While connecting to Windows server ( 2008 or 2012 ), Num pad keys not working even num lock is on.

Advise me what can be problem in configuration.


Jignesh
Reply | Threaded
Open this post in threaded view
|

Re: Keyboard Numpad keys issue

Mike Jumper
On Thu, Dec 1, 2016 at 9:58 AM, Jignesh Patel <[hidden email]> wrote:
> Hi,
>
> I have build Client and Server from 0.9.9 source.
>
> While connecting to Windows server ( 2008 or 2012 ), Num pad keys not
> working even num lock is on.
>
> Advise me what can be problem in configuration.
>

Hi Jignesh,

The issue you describe is a known bug in 0.9.9:

https://issues.apache.org/jira/browse/GUACAMOLE-51

It has since been fixed on git.

- Mike
Reply | Threaded
Open this post in threaded view
|

Re: Keyboard Numpad keys issue

Processor
In reply to this post by Jignesh Patel
No it's a known bug.

Corrected in the 0.9.10 Incubating

There is a fix, but you'll have to patch the sources. If you want I can provide this to you.

2016-12-01 18:58 GMT+01:00 Jignesh Patel <[hidden email]>:
Hi,

I have build Client and Server from 0.9.9 source.

While connecting to Windows server ( 2008 or 2012 ), Num pad keys not working even num lock is on.

Advise me what can be problem in configuration.


Jignesh

Reply | Threaded
Open this post in threaded view
|

Re: Keyboard Numpad keys issue

Processor
This is the fix :

{{

      • src/protocols/rdp/guac_handlers.c.orig Tue Dec 15 06:53:50 2015
      • src/protocols/rdp/guac_handlers.c Tue Jan 5 16:50:19 2016
        ***************
      • 489,494 ****
      • 489,504 ----

rdp_guac_client_data* guac_client_data = (rdp_guac_client_data*) client->data;

+ /* Inspired by the freerdp_focus_required() call in client/X11/xf_client.c */
+ /* We delay the TS_SYNC_EVENT until the first key press (instead of the event loop) due to a timing issue with Windows 2012, ref. */
+ /* https://social.msdn.microsoft.com/Forums/en-US/75024a3d-458f-4ed9-b55d-7852d0113bd7/rdpbcgrpdf-2-minors-problems-with-server-2012 */
+ static int first_key = 1;
+ if (first_key && pressed)

{ + rdpInput* input = guac_client_data->rdp_inst->input; + input->SynchronizeEvent(input, KBD_SYNC_NUM_LOCK); + first_key = 0; + }

+
/* Update keysym state */
if (GUAC_RDP_KEYSYM_STORABLE(keysym))
GUAC_RDP_KEYSYM_LOOKUP(guac_client_data->keysym_state, keysym) = pressed;
}}


Bye

2016-12-02 10:29 GMT+01:00 Processor <[hidden email]>:
No it's a known bug.

Corrected in the 0.9.10 Incubating

There is a fix, but you'll have to patch the sources. If you want I can provide this to you.

2016-12-01 18:58 GMT+01:00 Jignesh Patel <[hidden email]>:
Hi,

I have build Client and Server from 0.9.9 source.

While connecting to Windows server ( 2008 or 2012 ), Num pad keys not working even num lock is on.

Advise me what can be problem in configuration.


Jignesh


Reply | Threaded
Open this post in threaded view
|

Re: Keyboard Numpad keys issue

Jignesh Patel
Hi,

Thanks for prompt support and code.

given code works well and now Num pad keys work fine.

Jignesh

On Fri, Dec 2, 2016 at 8:09 PM, Processor <[hidden email]> wrote:
This is the fix :

{{

      • src/protocols/rdp/guac_handlers.c.orig Tue Dec 15 06:53:50 2015
      • src/protocols/rdp/guac_handlers.c Tue Jan 5 16:50:19 2016
        ***************
      • 489,494 ****
      • 489,504 ----

rdp_guac_client_data* guac_client_data = (rdp_guac_client_data*) client->data;

+ /* Inspired by the freerdp_focus_required() call in client/X11/xf_client.c */
+ /* We delay the TS_SYNC_EVENT until the first key press (instead of the event loop) due to a timing issue with Windows 2012, ref. */
+ /* https://social.msdn.microsoft.com/Forums/en-US/75024a3d-458f-4ed9-b55d-7852d0113bd7/rdpbcgrpdf-2-minors-problems-with-server-2012 */
+ static int first_key = 1;
+ if (first_key && pressed)

{ + rdpInput* input = guac_client_data->rdp_inst->input; + input->SynchronizeEvent(input, KBD_SYNC_NUM_LOCK); + first_key = 0; + }

+
/* Update keysym state */
if (GUAC_RDP_KEYSYM_STORABLE(keysym))
GUAC_RDP_KEYSYM_LOOKUP(guac_client_data->keysym_state, keysym) = pressed;
}}


Bye

2016-12-02 10:29 GMT+01:00 Processor <[hidden email]>:
No it's a known bug.

Corrected in the 0.9.10 Incubating

There is a fix, but you'll have to patch the sources. If you want I can provide this to you.

2016-12-01 18:58 GMT+01:00 Jignesh Patel <[hidden email]>:
Hi,

I have build Client and Server from 0.9.9 source.

While connecting to Windows server ( 2008 or 2012 ), Num pad keys not working even num lock is on.

Advise me what can be problem in configuration.


Jignesh